You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
OAuth userinfo get from Idp should be cached. (userinfo from http-server.authentication.oauth2.userinfo-url)
Otherwise every time a user access WEB_UI API will trigger a HTTP call from coordinator to Idp to fetch userinfo.
Trino WebUI constantly fetch from /ui/api/stats, /ui/api/cluster, and /ui/api/query. Each API call will trigger a HTTP call to Idp in coordinator.
OAuth userinfo get from Idp should be cached. (userinfo from
http-server.authentication.oauth2.userinfo-url
)Otherwise every time a user access WEB_UI API will trigger a HTTP call from coordinator to Idp to fetch userinfo.
Trino WebUI constantly fetch from
/ui/api/stats
,/ui/api/cluster
, and/ui/api/query
. Each API call will trigger a HTTP call to Idp in coordinator.Benefits of adding a cache:
trino/core/trino-main/src/main/java/io/trino/server/security/oauth2/NimbusOAuth2Client.java
Lines 397 to 400 in 6d20ac2
Call stack:
A naive cache implementation on queryUserInfo() shows significant improvement on latency.
Before:
After:
The text was updated successfully, but these errors were encountered: