Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send extra credentials only in the initial request instead of every request #243

Open
hashhar opened this issue Oct 1, 2022 · 3 comments

Comments

@hashhar
Copy link
Member

hashhar commented Oct 1, 2022

Client should send extra credentials only on the initial request.

See trinodb/trino#14364 (comment) for more context.

@hashhar
Copy link
Member Author

hashhar commented Oct 1, 2022

I need to add either another issue template or allow non-templated issues to track such TODO items - it's more noise than information for such issues.

Not needed, there's a Don’t see your issue here? Open a blank issue. button at the bottom already.

@aakashnand
Copy link
Member

@hashhar I would like to take this. Could you please give me some pointers, to begin with? I have skimmed through client.py and auth.py but was not able to understand where we make the initial connection and how we check if it's an initial request?

@mdesmet
Copy link
Contributor

mdesmet commented Mar 1, 2023

@aakashnand: The initial request is the query submission, i.e. the POST statement, the subsequent GET statements or other API calls shouldn't include the extra credentials.

Let me know if this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants