Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too large headers when inserting data #148

Open
mewa opened this issue Dec 29, 2021 · 0 comments
Open

Too large headers when inserting data #148

mewa opened this issue Dec 29, 2021 · 0 comments

Comments

@mewa
Copy link

mewa commented Dec 29, 2021

We're having an issue with too big headers being passed between the client and the server when inserting bigger chunks of data. Namely, the X-Trino-Added-Prepare header (this has already been mentioned in trinodb/trino#8797). The way it's passed down and back to the server makes it very unwieldy to process queries with a large number of parameters (as is the case when inserting many values). It requires configuring all the proxies and clients (including monkey-patching the python HTTP client) along the way to values way beyond sensible.

It seems that the issue we're running into is that the inserts shouldn't have been prepared statements in the first place (especially since currently you cannot reuse them for uploading different chunks of data as they get deallocated immediately after the query has been executed).

As such, I think it would be good to have the option to skip using prepared statements which generate really bulky X-Trino-Added-Prepare headers (introduced in #41), in particular in the insert scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant