Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queries sometimes fail when decoding progress percent in the response #116

Open
nineinchnick opened this issue May 3, 2024 · 0 comments · May be fixed by #117
Open

Queries sometimes fail when decoding progress percent in the response #116

nineinchnick opened this issue May 3, 2024 · 0 comments · May be fixed by #117

Comments

@nineinchnick
Copy link
Member

As reported in trinodb/grafana-trino#258, queries sometimes fail with:

error querying the database: trino: json: cannot unmarshal string into Go struct field stmtStats.stats.progressPercentage of type float32

The progressPercent field is declared as a float32: https://github.com/trinodb/trino-go-client/blob/master/trino/trino.go#L722, but the Trino server uses an OptionalDouble: https://github.com/trinodb/trino/blob/ca209630136eabda2449594ef2b6a4d82fb9c2e5/core/trino-main/src/main/java/io/trino/server/QueryProgressStats.java#L132

The driver should ignore invalid values in stats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant