We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit: Created a PR: #149
When using aws-load-balancer-controller, it is useful to pass annotations in the Service ( https://github.com/trinodb/charts/blob/trino-0.19.0/charts/trino/templates/service.yaml ) to denote what properties the load balancer could have.
Proposed solution: From https://github.com/trinodb/charts/blob/trino-0.19.0/charts/trino/values.yaml#L226
service: type: ClusterIP port: 8080 annotations: {} # <--------- this field is new
From https://github.com/trinodb/charts/blob/trino-0.19.0/charts/trino/templates/service.yaml
metadata: name: {{ template "trino.fullname" . }} labels: app: {{ template "trino.name" . }} chart: {{ template "trino.chart" . }} release: {{ .Release.Name }} heritage: {{ .Release.Service }} ####### # This section is new ######## {{- with .Values.service.annotations }} annotations: {{- toYaml . | nindent 4 }} {{- end }} ####### # /This section is new ######## spec:
I could make a pull request if you'd like.
The text was updated successfully, but these errors were encountered:
Created a PR: #149
Sorry, something went wrong.
No branches or pull requests
Edit: Created a PR: #149
When using aws-load-balancer-controller, it is useful to pass annotations in the Service ( https://github.com/trinodb/charts/blob/trino-0.19.0/charts/trino/templates/service.yaml ) to denote what properties the load balancer could have.
Proposed solution:
From https://github.com/trinodb/charts/blob/trino-0.19.0/charts/trino/values.yaml#L226
From https://github.com/trinodb/charts/blob/trino-0.19.0/charts/trino/templates/service.yaml
I could make a pull request if you'd like.
The text was updated successfully, but these errors were encountered: