No longer able to unbind j/k on google

[heyzec]

• Brief description of the problem:

  • I am using the Web Search Navigator add-on, which allows the user to move up and down results on websites such as google using the keys j and k. In order to achieve this, I've unbinded j and k in my config.
  • The odd thing is that this workflow used to work on previous versions of tridactyl. I've managed to get it work by reverting to 1.23.0 from the Firefox store, but the latest 1.24.0 does not work.
  • Building from source and doing git bisect gives: 608744b is the first bad commit. However, this commit is to fix focusinput's weird behaviour on google search box #4706, and it is not obvious to me how this change would affect this issue.

• Steps to reproduce:

  1. Install Web Search Navigator. No need to change any of its configs.
  2. Go to google and hit j/k. The indicator should move up and down, not the viewport.
     • Expected: On 608744b^, the indicator by Web Search Navigator moves up/down when k/j is pressed respectively
     • Actual: On 608744b, the indicator does not move. Instead, the page is scrolled with the amount depending on the original binds of j and k.

• Tridactyl version (:version): 1.24.0

• Firefox version (Top right menu > Help > About Firefox):
  Firefox 123.0 and Floorp 11.10.5

• URL of the website the bug happens on:
  https://www.google.com/search

• Contents of ~/.tridactylrc or ~/.config/tridactyl/tridactylrc (if they exist):

  sanitize tridactyllocal tridactylsync
  
  " For debugging purposes
  bind j scrollline 1
  bind k scrollline -1
  
  set theme shydactyl
  
  unbindurl www.google.com j
  unbindurl www.google.com k
  

[bovine3dom]

Reproducible. It is that commit that broke it :)

There is somehow a conflict between default subconfigs and null binds:

1. if there's a default subconfig for nmaps for a url, :unbindurl doesn't correctly unbind any key.
2. null does not work in default subconfig nmaps, the key does not get unbound

[bovine3dom]

As a workaround for you, could you switch to using a different domain such as google.co.uk where our default bind won't apply? E.g. :set searchurls.google https://www.google.co.uk/search?q=

[heyzec]

Thanks for the quick response! That workaround should be fine for me, otherwise I shall just continue using 1.23.0 for the time being :)