Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cleanslate with shadow dom #1140

Open
glacambre opened this issue Nov 2, 2018 · 8 comments
Open

Replace cleanslate with shadow dom #1140

glacambre opened this issue Nov 2, 2018 · 8 comments

Comments

@glacambre
Copy link
Member

As mentionned by @bovine3dom in #1134

@glacambre
Copy link
Member Author

Looks like we'll have to wait a year if we don't want to break ESR compatibility or maintain two versions of the command line: https://en.wikipedia.org/wiki/Firefox_version_history#Firefox_60.3esr

@bovine3dom
Copy link
Member

Oh wow, that would be a pain. We can just set min version to something so that ESR will at least get an old working version. Let's see how many ESR users we have and make a call.

@glacambre
Copy link
Member Author

@glacambre
Copy link
Member Author

We can also use the all css property in order to reset an element's CSS. Shadow DOM is better though.

@bovine3dom
Copy link
Member

Looks like we'll have to wait a year if we don't want to break ESR compatibility or maintain two versions of the command line

I have been consciously only supporting Firefox stable (except with backported security patches for ESR) for a while now, so this actually probably wasn't blocked for very long at all.

@bovine3dom
Copy link
Member

Related to #112

@bovine3dom
Copy link
Member

Vimium uses the shadow DOM and that apparently makes it more resistant to fingerprinting - philc/vimium#2399

@glacambre
Copy link
Member Author

glacambre commented Feb 28, 2023

In the case of Tridactyl, it wouldn't. Frames are still accessible through window.frames and you can access their url (which contains a user-specific add-on installation ID). Changing the name of the HTML document of the command line to something like "index.html" (which is what I use in Firenvim) might help a little but not much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants