undocumented use of Eric Niebler's ranges implementation

[jeffhammond]

You include range/v3/all.hpp but it appears neither in https://github.com/triSYCL/triSYCL/blob/master/doc/cmake.rst nor https://github.com/triSYCL/triSYCL/blob/master/README.rst.

I am trying to document the MacOS build instructions you requested in AdaptiveCpp/AdaptiveCpp#228 (comment) 😉

https://github.com/triSYCL/triSYCL/blob/master/doc/cmake.rst

Setup

jrhammon-mac02:build jrhammon$ export BREW_LLVM=/usr/local/Cellar/llvm/10.0.0_3
jrhammon-mac02:build jrhammon$ export CXX=$BREW_LLVM/bin/clang++
jrhammon-mac02:build jrhammon$ export CC=$BREW_LLVM/bin/clang

CMake

jrhammon-mac02:build jrhammon$ cmake ..
-- The CXX compiler identification is Clang 10.0.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/local/Cellar/llvm/10.0.0_3/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- host compiler - clang 10.0.0
-- Found triSYCL include directory: /Users/jrhammon/Work/SYCL/triSYCL/include
-- Found OpenMP_CXX: -fopenmp=libiomp5 (found version "4.5") 
-- Found OpenMP: TRUE (found version "4.5")  
-- Found Boost: /usr/local/lib/cmake/Boost-1.73.0/BoostConfig.cmake (found suitable version "1.73.0", minimum required is "1.65") found components: chrono fiber log thread 
-- triSYCL OpenMP:                   ON
-- triSYCL TBB:                      OFF
-- triSYCL OpenCL:                   OFF
-- triSYCL synchronous execution:    OFF
-- triSYCL debug mode:               OFF
-- triSYCL object trace:             OFF
-- triSYCL kernel trace:             OFF
-- Found Threads: TRUE  
-- The C compiler identification is Clang 10.0.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/local/Cellar/llvm/10.0.0_3/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/jrhammon/Work/SYCL/triSYCL/build

Build error

jrhammon-mac02:build jrhammon$ make -j2 -k
...
[ 33%] Building CXX object tests/detail/CMakeFiles/detail_fiber_pool.dir/fiber_pool.cpp.o
In file included from /Users/jrhammon/Work/SYCL/triSYCL/tests/detail/fiber_pool.cpp:11:
/Users/jrhammon/Work/SYCL/triSYCL/include/triSYCL/detail/fiber_pool.hpp:27:10: fatal error: 'range/v3/all.hpp' file not found
#include <range/v3/all.hpp>
         ^~~~~~~~~~~~~~~~~~
1 error generated.

[jeffhammond]

Given that this is a relatively small library, I wonder if it makes sense to include via submodule rather than an external dependency.

[keryell]

Good point!
Actually it is mainly used by triSYCL for some non published versions of triSYCL yet.

[keryell]

range-v3 is not a small library, considering the impact on ISO C++ and the brain concentrate it owns. :-)
So it seems preferable to just add it as a normal dependency, as envisioned in #289

[keryell]

Now the hidden dependency on https://github.com/ericniebler/range-v3/blob/master/include/range/v3/all.hpp is solved with #306