chore(core) rename Shamir to Multi-share #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Please merge after #3696 |
|
Don't we also want to rename the identifiers of strings? |
Hannsek
reviewed
May 8, 2024
core/mocks/trezortranslate_keys.pyi
Outdated
| @@ -601,15 +601,15 @@ class TR: | |||
| reset__threshold_info: str = "= minimum number of unique word lists used for recovery." | |||
| reset__title_backup_is_done: str = "BACKUP IS DONE" | |||
| reset__title_create_wallet: str = "CREATE WALLET" | |||
| reset__title_create_wallet_shamir: str = "CREATE WALLET (SHAMIR)" | |||
| reset__title_create_wallet_shamir: str = "CREATE WALLET (MULTI-SHARE)" | |||
There was a problem hiding this comment.
This would be visible also when user is creating 1 of 1 right?
During the creation of 1of1 shamir, there cannot be a term multi-share...
There was a problem hiding this comment.
Good point. I'll use something else in that case. What should it be? "single share"?
There was a problem hiding this comment.
No, we now cannot distinguish which type of backup user would do (single-share or multi-share). So for now on deviceReset let's use just Create wallet as in bip39 flow.
ibz
force-pushed
the
ibz/20240508-shamir
branch
2 times, most recently
from
2188ef3
to
954c02b
Compare
|
obrusvit
added
the
translations
obrusvit
requested changes
May 10, 2024
[no changelog]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3792 & #3793