Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to package #562

Open
mar-pan opened this issue Jan 2, 2024 · 3 comments
Open

Add typing to package #562

mar-pan opened this issue Jan 2, 2024 · 3 comments
Labels
Feature Feature request Tech debt Technical debt

Comments

@mar-pan
Copy link

mar-pan commented Jan 2, 2024

When trying to lint code piece which is using your package with mypy it says that
module is installed, but missing library stubs or py.typed marker

please add those it should be simple according to https://blog.whtsky.me/tech/2021/dont-forget-py.typed-for-your-typed-python-package/#adding-pytyped

@nicholasserra nicholasserra added Feature Feature request Tech debt Technical debt labels Jan 3, 2024
@Crozzers Crozzers mentioned this issue Jan 3, 2024
@Crozzers
Copy link
Contributor

Crozzers commented Jan 3, 2024

There's a pending PR that drops Python 3.5, so if that goes through I'd be happy to add some inline type hints for the main user facing API

@mar-pan
Copy link
Author

mar-pan commented Feb 11, 2024

Hello how it's going

@Crozzers
Copy link
Contributor

The PR I'm waiting on has received some updates and once it gets merged we can start adding type hints to the package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature request Tech debt Technical debt
Projects
None yet
Development

No branches or pull requests

3 participants