Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra 'task_list' option, the html does not preform like github. #321

Open
1 of 2 tasks
qinggniq opened this issue Jan 14, 2019 · 2 comments
Open
1 of 2 tasks
Labels
Feature Feature request

Comments

@qinggniq
Copy link

qinggniq commented Jan 14, 2019

I add 'task_list' option, and the html performed like this:

    • task list item
      but the github task list item performed like this:
  • task list item
    never mind that I used the wrong markdown syntax to show the result, for I can not insert the image.
    I found the html converted by markdown2 is like blow:
<li><p><input type="checkbox" class="task-list-item-checkbox" %sdisabled>%s</p></li>

and it will be format with the "checked" status and the real text after "- [ ]" or "- [x]", but the above html code can not performed like github, because the task list items at github do not have the list leader, while the list items of above html will have.
I want to make it perform like github, but the generate rule does not leave me any space to make me write the class selector to modify the performance of the items of task list. So I think why not change the generate style to make it performed like github like below:

 return "<li class='task-list-item'>%s</li>\n" % item
//line 1689 at markdown2.py 

So I can write class selector to make it perform like github.

.markdown-body .task-list-item {
  list-style-type: none;
}

or change like blow:

 return "<li style='list-style-type: none;'>%s</li>\n" % item

No need to write CSS handly.

@handbye
Copy link

handbye commented Feb 25, 2019

good job!

@DingBL
Copy link

DingBL commented May 29, 2019

  • good job

:octocat: From gitme iOS

@nicholasserra nicholasserra added the Feature Feature request label Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature request
Projects
None yet
Development

No branches or pull requests

4 participants