Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with new sarama #161

Open
Serhii1011010 opened this issue Feb 25, 2020 · 1 comment
Open

Doesn't work with new sarama #161

Serhii1011010 opened this issue Feb 25, 2020 · 1 comment

Comments

@Serhii1011010
Copy link

Serhii1011010 commented Feb 25, 2020

Steps to reproduce:

1 clone this repository
2 go to _examples/sarama dir
3 modify it to be up to date
4 go run main.go

everything is fine so far

5 change go.mod's sarama version to, say, v1.26.1
6 get out of memory error

The error is happening here https://github.com/travisjeffery/jocko/blob/master/protocol/decoder.go#L277 because this conversion https://github.com/travisjeffery/jocko/blob/master/protocol/decoder.go#L266 makes n to be 4294967295, which is probably because sarama changed endianness in their protocol.

@Serhii1011010
Copy link
Author

The issue appears in 1.17.0 version of sarama. 1.16.0 still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant