Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working for 2022 release #122

Open
see24 opened this issue Jul 6, 2023 · 10 comments
Open

Not working for 2022 release #122

see24 opened this issue Jul 6, 2023 · 10 comments

Comments

@see24
Copy link

see24 commented Jul 6, 2023

The package was not working for the 2022 release even when I supplied the right sb_id there were apparently a few small changes in the data format that messed things up.

I will make a PR with changes I made to fix it.

@rburner
Copy link

rburner commented Jul 20, 2023

Hi @trashbirdecology and @see24 - I'm having the same problem; do you think this will be resolved soon? Thanks!

@see24
Copy link
Author

see24 commented Jul 20, 2023

@rburner you could try installing from my fork https://github.com/see24/bbsAssistant/tree/fix-QualityCurrentID-filter

Not sure how actively this project is being maintained.

@rburner
Copy link

rburner commented Jul 20, 2023

Thank you @see24 ! I appreciate it.

For others, install can be done with:
devtools::install_github("see24/bbsAssistant")

But when I try it with 2022 data (sb_id='625f151ed34e85fa62b7f926') I get the following:

Error in `$<-`:
! Assigned data `as.integer(as.character(species_list$AOU))` must be compatible with existing data.
✖ Existing data has 764 rows.
✖ Assigned data has 0 rows.
ℹ Only vectors of size 1 are recycled.
Caused by error in `vectbl_recycle_rhs_rows()`:
! Can't recycle input of size 0 to size 764.
Run `rlang::last_trace()` to see where the error occurred.
Warning message:
Unknown or uninitialised column: `AOU`. 

For 2023 data (sb_id='64ad9c3dd34e70357a292cee') I'm getting the following (different) error:

Joining with `by = join_by(Seq, AOU, English_Common_Name, Spanish_Common_Name, ORDER, Family, Genus, Species)`
Error in enc2utf8(path) : argument is not a character vector

@see24
Copy link
Author

see24 commented Jul 21, 2023

Hi @rburner I think the issue is that you actually need a specific branch of my fork of the repo.
Try: devtools::install_github("see24/bbsAssistant", ref = "fix-QualityCurrentID-filter")

@rburner
Copy link

rburner commented Jul 21, 2023

@see24 Good call, that works great with 2022! Thank you!

For 2023 though I get this error now:
Attempting to decompress and import files from data-in/64ad9c3dd34e70357a292cee Error in enc2utf8(path) : argument is not a character vector

I don't specifically need 2023 data, so feel free to ignore this though:) Thanks again

@rburner
Copy link

rburner commented Jul 21, 2023

@see24 Although I am finding one issue with 2022 (FYI - I can overcome it by using the built-in package species list) - when I run:
bbs <- grab_bbs_data(sb_id='625f151ed34e85fa62b7f926') #2022
and then look at
bbs$species_list
all of Passeriformes (but not other species) is missing scientific name, AOU4, and AOU6.

But, if I just look at
species_list
the codes are all there. If I understand the documentation correctly I think the former is the list from the current downloaded dataset, and the latter is the version loaded automatically with the package.

@see24
Copy link
Author

see24 commented Jul 21, 2023

I just made another push to that branch, should fix the Passeriformes issue but there are still some species not matching because of different scientific names than the ones in the list that is included with the package. Probably would be better to use the IBP-AOS list that corresponds to the bbs release year but don't know where to find old ones.

@trashbirdecology
Copy link
Owner

trashbirdecology commented Jul 23, 2023 via email

@rburner
Copy link

rburner commented Jul 24, 2023

Thank you both! I really appreciate the fixes.

@trashbirdecology
Copy link
Owner

trashbirdecology commented Jul 28, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants