New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ability to submit lrc files without spaces b/w timestamps and lyrics #32

Open

Dr-Blank opened this issue Dec 2, 2023 · 1 comment

Labels

Dr-Blank commented Dec 2, 2023

as on the wikipedia page, it is a valid lrc even if there is no space between timestamps and the lyrics

the rendering of lyrcis by all players, even lrcget does not get affected by it.

api accepts those lyrics without raising error. although I am not even sure if it rejects anything, is there a format checking for the publish api?

Owner

tranxuanthang commented Jan 14, 2024

The linter only runs on client-side. There is no server-side check at the moment. This is enforced for style consistency, the LRC file is still valid and readable by LRCGET with or without space between the timestamp and the lyrics.

I think similar to most programming language linters, we can implement an auto "fix all" button, it would indeed save a lot of time for users.

tranxuanthang added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment