Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tracks that already have lyrics only skips tracks that have LRC lyrics #30

Open
ThaiWood opened this issue Nov 24, 2023 · 2 comments

Comments

@ThaiWood
Copy link

I'm not sure if its intentional, but I was surprised to discover that the setting "Skip tracks that already have lyrics or are instrumental" only check if they have LRC lyrics and not plain lyrics.

This means that if you stop part way through (especially in a large library) and have several tracks that have plain lyrics only, they will be re-downloaded every time.

I understand that perhaps folks may want to "upgrade" and have a search that tries to get LRC lyrics each time, but perhaps that could be a seperate setting?

@tranxuanthang
Copy link
Owner

It is intentional, because my aim for LRCGET is that it focuses more on synchronized lyrics. But I think your suggestion does make sense. I'll look into it and see what I can do.

@mnvfs
Copy link

mnvfs commented Mar 4, 2024

Trying to upgrade from unsynced to synced is a perfect behavior for me. But I think if there are no synced lyrics available but plain lyrics are availabe and do already exist on disk they should not be downloaded again. This creates an unnecessary file change and may be a problem when syncing files between two or more stores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants