Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start pre-review of effect size guideline #50

Open
mjskay opened this issue Jul 7, 2017 · 3 comments
Open

Start pre-review of effect size guideline #50

mjskay opened this issue Jul 7, 2017 · 3 comments

Comments

@mjskay
Copy link
Member

mjskay commented Jul 7, 2017

Sometime in the next two days I'm going to finish my changes to the simple effect size exemplar (i.e. addressing Chat's comments --- this is mostly already done).

Once that is merged, I am planning to start a pull request for the effect-size branch onto master (with no intention of merging it just yet). I do not think that the effect size guideline is actually at a final state yet, but I think it is close enough to use a pull request to get us moving towards a final state and as a "pre-review": creating the pull request would allow us to comment on the effect size doc line-by-line. The nice thing about pull requests are that they aren't static, so as we address each others' comments by making changes to the effect size branch, stale comments (attached to changed content) will be resolved. In this way we can use the PR to do a "continuing review" of the doc until we think it is ready for the next step (review by two experts, etc). If that works out, perhaps using a PR for continuing review might be something we put in the review process document.

Does this sound good to others? @chatchavan @dragice @shionguha @steveharoz

@steveharoz
Copy link
Contributor

I haven't done a real pass at the FAQ. I'll try to go through it tomorrow.

@chatchavan
Copy link
Collaborator

Sounds good to me.

@shionguha
Copy link

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants