Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameter redundancy for toKeyPair method #340

Open
acarnagey opened this issue Jan 5, 2022 · 1 comment
Open

Remove parameter redundancy for toKeyPair method #340

acarnagey opened this issue Jan 5, 2022 · 1 comment

Comments

@acarnagey
Copy link
Member

Used for wallet and crypto libraries.

index and hdPath are redundant.

Ethereum — m'/44’/${assumedCoinType}’/0’/0/${index}... vs .... m'/44’/60’/0’/0/0.

Should just use hdpath param, remove index.

@OR13
Copy link
Sponsor Member

OR13 commented Jan 5, 2022

This might effect a lot of stuff, and any static test vectors that were built from the old format will need to be aligned to the new method signature after the change is mage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants