Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable scheduled tests #142

Open
mifi opened this issue Jul 28, 2022 · 1 comment
Open

re-enable scheduled tests #142

mifi opened this issue Jul 28, 2022 · 1 comment
Assignees
Labels
prio-3 sdks Integrations for Transloadit's API

Comments

@mifi
Copy link
Collaborator

mifi commented Jul 28, 2022

until we can implement a localtunnel replacement, I disabled the scheduled tests in 90cdfc6 in order to reduce noise. need to re-enable

#89 (comment)

@lekevbot lekevbot added the sdks Integrations for Transloadit's API label Jul 28, 2022
@mifi
Copy link
Collaborator Author

mifi commented Aug 1, 2022

now that the cloudflare tunnel is implemented, we could close this, but fixing the tunnel reveals that the eventual consistency in api2 is still an issue, causing the same test to fail sporadically, so we need to fix that first:


  ● API integration › assembly cancelation › should stop the assembly from reaching completion

    expect(received).toBe(expected) // Object.is equality

    Expected: "ASSEMBLY_CANCELED"
    Received: "ASSEMBLY_EXECUTING"

      445 |         const resp2 = await client.getAssembly(id)
      446 |         console.log(`Expect Assembly ${id} to return 'ASSEMBLY_CANCELED'`)
    > 447 |         expect(resp2.ok).toBe('ASSEMBLY_CANCELED')
          |                          ^
      448 | 
      449 |         // Check that awaitAssemblyCompletion gave the correct response too
      450 |         const awaitCompletionResponse = await awaitCompletionPromise

      at Object.it (test/integration/__tests__/live-api.js:447:26)

https://github.com/transloadit/node-sdk/runs/7617455306?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-3 sdks Integrations for Transloadit's API
Projects
None yet
Development

No branches or pull requests

2 participants