Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convex_hull buffer for small geometry collections #1076

Open
slvlirnoff opened this issue May 1, 2017 · 1 comment
Open

convex_hull buffer for small geometry collections #1076

slvlirnoff opened this issue May 1, 2017 · 1 comment
Assignees

Comments

@slvlirnoff
Copy link

For geometries collection of less than 3 elements, the datastore adds a buffer of 100 lat/lon to the generated convex_hull. (https://github.com/transitland/transitland-datastore/blob/master/app/models/concerns/has_a_geographic_geometry.rb#L27)

This seems very high and make operator bounding box very hard to use/covers half the planet.

Is there a specific reason for such a high value? I've tested with a buffer of 0.1 and it does look much nicer on mobility explorer.

For feeds like switzerland official where there's a bit more than an hundred operators with 2 stops (ski lift for instance or funicular) it'd seems quite good to revisit that number.

@irees
Copy link
Member

irees commented May 1, 2017

Hello again @slvlirnoff !

I think the intention was 100m -- I will look into it and make an adjustment if necessary.

@irees irees self-assigned this May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants