Skip to content
This repository has been archived by the owner on Apr 1, 2023. It is now read-only.

comments stripped from output with --no-compress #370

Open
nreh opened this issue Aug 3, 2022 · 1 comment
Open

comments stripped from output with --no-compress #370

nreh opened this issue Aug 3, 2022 · 1 comment

Comments

@nreh
Copy link

nreh commented Aug 3, 2022

Basically reposting this issue: developit/microbundle#647

I'm a newbie to bundling and library creation so take what I say with a grain of salt.

I was looking at package.json and see that you're using microbundle-crl instead of microbundle which is apparently a fork with improved features and defaults for react. However, there was an issue with microbundle where --no-compress would remove comments from the output which was fixed in developit/microbundle#648. Unfortunately, this issue still exists in microbundle-crl and by replacing mircobundle-crl with microbundle in package.json I was able to keep the comments in my code.

I read your comment (#238 (comment)) and agree with what you said and am thinking that maybe that this might be an accidentally oversight. I'm not exactly sure about the specific improvements of microbundle-crl over the original so I'd rather use microbundle-crl - however, the no comments thing is kind of a deal breaker.

Thanks, and would appreciate any clarification or workaround.

@nreh
Copy link
Author

nreh commented Aug 3, 2022

I literally just saw this 🤦:

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant