Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option that will only download 100% translated/reviewed languages #313

Open
Sopor opened this issue Dec 30, 2020 · 6 comments
Open

Comments

@Sopor
Copy link

Sopor commented Dec 30, 2020

If i only want to download a language that is 100% translated and 100% reviewed there is no option for that. In the config file i can add minimum_perc = 100 but that will download even if it is 0% reviewed. So if a language is translated to 100% but not reviewed it will download the language file.

I have tried with --mode onlyreviewed, but it will still download all languages, but it will leave non reviewed strings empty.

Here are the different modes i can use and none of them suits my need:

  • translator: The files will be suitable for offline translation. Equivalent to the web app's option "Download file to translate" (for_translation).

  • reviewed: The files will include reviewed strings in the translation language. All other strings will either be empty or in the source language depending on the file format.

  • onlytranslated: The files will include the translated strings. The untranslated ones will be left empty.

  • onlyreviewed: The files will only include reviewed strings. The rest of the strings will be returned empty regardless of if they’re translated or not.

So could you add an option that will download the language file only if it is 100% translated and 100% reviewed?

@adimitrokalis
Copy link

Hello. Thank you for reaching out to us. Please look at the following entry in our documentation for handling 100% reviewed translations : https://docs.transifex.com/client/pull#pulling-translations-that-have-been-reviewed. Please let us know if this helps.

@Sopor
Copy link
Author

Sopor commented Dec 31, 2020

It seems that it works if i use --mode reviewed. I never tried that and of course minimum_perc = 100 but i have that in the config file.

Thanks!

@Sopor Sopor closed this as completed Dec 31, 2020
@Sopor Sopor reopened this Jan 18, 2022
@Sopor
Copy link
Author

Sopor commented Jan 18, 2022

It seems that this will only work if i have one resource file. Is there a way to only download a 100% translated and reviewed language when the language contain more than one resource file?

If not, it would have been great if tx.exe will have support for it. Not all projects have a single file and if i only want to download languages that are 100% translated and reviewed that will be really hard :(

@Sopor
Copy link
Author

Sopor commented Jan 18, 2022

The --mode reviewed will download only reviewed strings, but if i only want to download 100% reviewed translations?

This is what reviewed do: The files will include reviewed strings in the translation language. All other strings will either be empty or in the source language depending on the file format.

As you can see it will download the reviewed strings and either leave the rest empty or it will use the source language. I want to be able to download only if 100% of the strings are reviewed. Similar to minimum_perc = 100 but for reviewed strings (minimumreviewed_perc = 100).

@pankav
Copy link

pankav commented Jan 20, 2022

Hello @Sopor ,

I am Panagiotis an engineer from the Transifex support team. According to your message, if I understood it correctly, you want somehow to have the option to download all the translation files of a (100% translated and reviewed )language of a specific project.
If that is the case, then, unfortunately, we don't have this feature. However, I will forward this to our product team for further evaluation.
Once I have an update I will let you know.

Please let me know if you have any further questions.

@Sopor
Copy link
Author

Sopor commented Jan 20, 2022

@pankav That sounds really nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants