Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx client misbehaviour: tx exits with code 0 even on error #175

Open
Mi605 opened this issue Mar 28, 2023 · 1 comment
Open

tx client misbehaviour: tx exits with code 0 even on error #175

Mi605 opened this issue Mar 28, 2023 · 1 comment

Comments

@Mi605
Copy link

Mi605 commented Mar 28, 2023

Scope:

  • TX Client, version=1.6.5

Focus:

  • tx client exit codes

Issue:

  • tx client exits with exit code 0 when it shouldn't. An exit code of 0 (zero) means on linux the program has done its tasks without error.
    Despite of this, tx client returns 0 even if it failed to finish its task properly.

Expected behaviour:

  • tx client mustn't return 0 (zero) in case of the requested task wasn't done.
    In case the command can't finish its task for some reason, it is expected to
    return at least a value of 1 (one), or a separate number other than zero for each type of error.

Example:

$ tx pull -s
# Getting info about resources

test-project.test-files - Resource test-project.test-files does not exist
[##############################] (1 / 1)

$ echo $?
0
@Mi605
Copy link
Author

Mi605 commented Mar 29, 2023

Additional information:
On some other error conditions tx client returns 1 (one) properly.
Re-checking the error described in #173, this time I counterchecked with echo $? after execution, and this command came properly back with 1 after the transmission of one of the files failed. So obviously only some of the tx commands are subject of not returning proper exit status after execution of the task failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant