Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #63

Open
elfring opened this issue May 25, 2016 · 2 comments
Open

reserved identifier violation #63

elfring opened this issue May 25, 2016 · 2 comments
Labels

Comments

@elfring
Copy link

elfring commented May 25, 2016

I would like to point out that identifiers like "__ARENA_H__" and "__TRAILDB_H__" do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

@whackashoe
Copy link
Contributor

Well this is C not C++, but in 7.1.3 of the C standard:

All identifiers that begin with an underscore and either an uppercase letter or another underscore are always reserved for any use.

So yeah, would be best if someone changed this.

@tuulos
Copy link
Member

tuulos commented May 27, 2016

Good point. We should change this.

@tuulos tuulos added the bug label Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants