'tdb_cursor_next' magic

[19h]

Hey,

I'm currently updating the TrailDB rust binding and noticed a strange behaviour where the binding generator isn't finding tdb_cursor_next.

Then I realized it's exported in a non-standard way:

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wmissing-prototypes"
__attribute__((visibility("default"))) inline const tdb_event *tdb_cursor_next(tdb_cursor *cursor)
{
    if (cursor->num_events_left > 0 || _tdb_cursor_next_batch(cursor)){
        const tdb_event *e = (const tdb_event*)cursor->next_event;
        cursor->next_event += sizeof(tdb_event) +
                              e->num_items * sizeof(tdb_item);
        --cursor->num_events_left;
        return e;
    }else
        return NULL;
}
#pragma GCC diagnostic pop

This is a huge problem for Clang because the GCC attributes effectively make the method invisible for the outside world. In the binding, I manually removed the attributes in order to have it compile using Clang.

-- Kenan

🚀

[Noeda]

IMO there should be an equivalent function in traildb.h that is otherwise exactly the same as tdb_cursor_next but is friendly to bindings. It's not just Clang world but also different language bindings would have slightly easier time binding to C APIs when they can't directly bind to inlined C functions. @tuulos