Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markers should have a price value/y-coordinate to point to the correct level of a buy/sell on the y axis (with positioning inBar) #1508

Open
maximbelyayev opened this issue Feb 1, 2024 · 4 comments
Labels
enhancement Feature requests, and general improvements. good first issue Good issue for first-time contributors.

Comments

@maximbelyayev
Copy link

Is your feature request related to a problem? Please describe.

Covered in the following issues:
#636

Describe the solution you'd like

"Arrows should point correctly at the pricelevel of buy/sell. The down-tip of the arrowDown should be placed at the price-level of the sell. The upwards tip of the arrowUp should be placed at the pricelevel of the buy.

I expect the arrow to point to the correct price level if positioning is "inBar", or expect that there would be another positioning option that would make the marker handle this case."

Additional context

In below example, current behavior results in a marker below $71, even though a sell occurred at $71.

image

@SlicedSilver SlicedSilver added enhancement Feature requests, and general improvements. good first issue Good issue for first-time contributors. labels Feb 1, 2024
@daryazata
Copy link

@SlicedSilver the issue was not resolved in the linked ticket? I can try to work on it.

@SlicedSilver
Copy link
Contributor

Yes, it is a feature which you could have a go at implementing.

First step would be to discuss the possible API change. Perhaps adding an optional property called price to the SeriesMarker interface. If it is provided then that price value is used for determining the location of the marker (instead of the bars close / value value).

@daryazata
Copy link

daryazata commented Feb 14, 2024

@SlicedSilver maybe we can chat about details on discord? also i get an error when running npm i, npm ERR! notarget No matching version found for call-bind@^1.0.7.

@fabriziogiordano
Copy link

@maximbelyayev if you feel courageous you can take these changes: https://github.com/fabriziogiordano/lightweight-charts-v4/commit/1957ed853346e2bcfd677e93d137360d12012f51 I needed the same thing and I forked the repo to add a price property to the SeriesMarker.

I will do an official fork and tests and send an official PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests, and general improvements. good first issue Good issue for first-time contributors.
Projects
None yet
Development

No branches or pull requests

4 participants