Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link in comment notification is wrong #47

Open
PhilippWendler opened this issue Sep 24, 2014 · 3 comments
Open

Link in comment notification is wrong #47

PhilippWendler opened this issue Sep 24, 2014 · 3 comments

Comments

@PhilippWendler
Copy link

My Trac instance is hosted at http://server/trac/project and I have specified this value as base_url in trac.ini.
When creating a comment (for a line of a file), the notification email contains the link http://server/trac/project/trac/project/browser/trunk/... (duplicate path prefix).

@schwuk schwuk self-assigned this Sep 30, 2014
@nb nb modified the milestones: core.trac.wordpress.org, 1.2.0 Sep 30, 2014
@schwuk
Copy link
Contributor

schwuk commented Oct 5, 2014

Unable to reproduce the duplicate path. Do you have multiple repositories configured?

@PhilippWendler
Copy link
Author

Yes, I have multiple repositories, but that part seems to be correct (so far I only tested the one repository that is the default repository in our project).
The full URL in the mail was https://svn.sosy-lab.org/trac/cpachecker/trac/cpachecker/browser/trunk/src/org/sosy_lab/cpachecker/cpa/predicate/synthesis/RelSynthTest.java?codecomment=3&rev=13706#L62.
base_url is set to https://svn.sosy-lab.org/trac/cpachecker.

The correct URL to the repository in the trac browser is https://svn.sosy-lab.org/trac/cpachecker/browser/CPAchecker/ or simply https://svn.sosy-lab.org/trac/cpachecker/browser/.

@schwuk
Copy link
Contributor

schwuk commented Oct 6, 2014

Managed to replicate this by running Trac with both base_url specified and under a different base path.

This is down to how we generate the href for a code comment and/or how we generate the URL for the notification. I need to fix one (or both) to allow for running under a base path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants