Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work at all for git repos #13

Open
rcarmo opened this issue May 14, 2012 · 6 comments
Open

Doesn't work at all for git repos #13

rcarmo opened this issue May 14, 2012 · 6 comments
Milestone

Comments

@rcarmo
Copy link

rcarmo commented May 14, 2012

I'm doing some basic testing, and apparently you're not allowing for revision ids with more than 3 characters (actually, just saw that you're using int as a revision type in the database - that won't work at all).

There might be more issues, but I've hit upon that one right away.

Removing the "int" specifier from the revision field in db.py appears to fix that across the board, in the sense that I now get a listing of the comments I made.

They still don't display, though, but I think the reason for that is #14.

@livedata
Copy link

it works for me

@rcarmo
Copy link
Author

rcarmo commented May 16, 2012

So which git plugin are you using, then? I've had this blow up on me when two revisions start with the same numerical prefix (92caef and 92b654) because only the '92' makes it thorough.

On MySQL, mind you. If you're using another database, the int field might not be as... Strict.

Hence my only way to make this work being changing the field type in the DB.

On 16/05/2012, at 20:09, livedatareply@reply.github.com wrote:

it works for me


Reply to this email directly or view it on GitHub:
#13 (comment)

@livedata
Copy link

I'm using sqlite and trac 0.13dev

@nb
Copy link
Contributor

nb commented May 17, 2012

Agreed, revision should have been a string. We will need to change the database column for that, though. I will get it in 1.2.0.

Orio91 pushed a commit to Orio91/trac-code-comments-plugin that referenced this issue Aug 16, 2012
Orio91 pushed a commit to Orio91/trac-code-comments-plugin that referenced this issue Sep 5, 2012
Orio91 pushed a commit to Orio91/trac-code-comments-plugin that referenced this issue Sep 10, 2012
@lkraav
Copy link

lkraav commented Oct 30, 2012

Hey all, letting you know I am about to jump on this issue's bandwagon. Just cherry-picked the @Orio91 patches and going to see how it goes. Both git and multiple repos are essential here.

@lkraav
Copy link

lkraav commented Oct 30, 2012

First of all, I don't think the v3 database migration works for Postgres. I'm hitting:

ProgrammingError: syntax error at or near "PRAGMA"
LINE 1: PRAGMA index_list(code_comments)
^

schwuk added a commit to schwuk/trac-code-comments-plugin that referenced this issue Aug 9, 2014
Create table for subscriptions.

Populate table with subscriptions for attachments and revisions.

Subscriptions will support multiple repositories and Git, even though
code comments themselves don't currently (trac-hacks#13 and trac-hacks#14).
schwuk added a commit to schwuk/trac-code-comments-plugin that referenced this issue Aug 9, 2014
Create table for subscriptions.

Populate table with subscriptions for attachments and revisions.

Subscriptions will support multiple repositories and Git, even though
code comments themselves don't currently (trac-hacks#13 and trac-hacks#14).
@nb nb modified the milestones: Future, 1.2.0 Sep 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants