Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in certain case of ds( #232

Open
jeaye opened this issue Jul 20, 2017 · 3 comments
Open

Bug in certain case of ds( #232

jeaye opened this issue Jul 20, 2017 · 3 comments

Comments

@jeaye
Copy link

jeaye commented Jul 20, 2017

Hey Tim,

I've hit this one a bunch of times and never saw a pattern in what was going on until recently. Here's a minimal reproduction (Clojure code):

(map (fn [x]
       (|f|oo x
            ))
     bar)

I'm using |f| to represent the cursor is on f. If I then run ds( or ds) or dsb I get the following:

(map foo x
     bar)

However, I would expect to get this instead:

(map (fn [x]
       foo x
       )
     bar)

The important part here is that the closing delimiter of the form getting its parens deleted is on a new line. Cheers!

@jeaye
Copy link
Author

jeaye commented Jul 20, 2017

I looked, but apparently not hard enough. It looks like this might be a duplicate of #215 which is resolved by the unmerged PR #217. I'll wait to see how you'd like to handle this.

@jeaye
Copy link
Author

jeaye commented Jan 2, 2018

Happy new year. Any update on this, Tim?

@Aster89
Copy link
Contributor

Aster89 commented Oct 11, 2021

This is another set of repro steps.

The file is

b((3
));

given the cursor is on the 3, hitting any of dsb, ds(, or ds) results in

b3;

However, the last commit on this repo is from November 2019, so I doubt I'll get any attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants