Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symmetric positive definite domain #6

Open
simonbyrne opened this issue Aug 30, 2018 · 10 comments
Open

symmetric positive definite domain #6

simonbyrne opened this issue Aug 30, 2018 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@simonbyrne
Copy link

Could you add a symmetric positive definite domain transformation? It could be based on the correlation one.

@tpapp
Copy link
Owner

tpapp commented Aug 30, 2018

I will add one (perhaps in the examples on how to use CustomTransform). But I am curious what you need it for, since in practice its Cholesky factor is much more useful for inference.

@tpapp tpapp self-assigned this Aug 30, 2018
@tpapp tpapp added the enhancement New feature or request label Aug 30, 2018
@simonbyrne
Copy link
Author

I have a model where the prior is inverse Wishart.

@tpapp
Copy link
Owner

tpapp commented Aug 31, 2018

I added it as a test/example.

I will think about adding it as a regular transform, but I don't think Wishart is a good prior, so I would rather encourage using half-Cauchy for standard deviations and LKJ for the correlation matrix (apologies if you know about this and decided you still need Wishart).

@simonbyrne
Copy link
Author

I agree, but i'm replicating someone else's results.

@simonbyrne
Copy link
Author

and thanks for the example!

@tpapp
Copy link
Owner

tpapp commented Sep 8, 2018

@simonbyrne: just to let you know, I am merging an API change now. I have updated the example in the tests.

If you are using this library in production, you may want to pin to df4234b, or update your code.

As the library is currently in development and I am experimenting, there will be no deprecations or releases until it stabilizes. So you may want to use Github's watch functionality for notifications.

@simonbyrne
Copy link
Author

simonbyrne commented Sep 9, 2018 via email

@aterenin
Copy link

+1 to please add this. I don't think preference against the Inverse Wishart prior is a strong reason not to include this transform - appropriateness of the Wishart/IW prior depends on the user's likelihood. I'm using a Wishart it for estimating a symmetric positive definite matrix that isn't a covariance (i.e. my likelihood is not multivariate Gaussian with unknown Sigma or anything remotely near), where LKJ is not necessarily appropriate, and Wishart with identity hyperparameter is a natural choice due to its group invariance properties.

@tpapp
Copy link
Owner

tpapp commented Dec 23, 2018

So would you need a transformation from an n⋅(n+1)/2 vector of reals to an n × n positive definite matrix?

@aterenin
Copy link

Yes - just as in Stan - this would be fantastic!

simonbyrne added a commit to simonbyrne/TransformVariables.jl that referenced this issue Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants