Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-View Video Player #70

Open
jwinarske opened this issue Jul 14, 2022 · 4 comments
Open

Multi-View Video Player #70

jwinarske opened this issue Jul 14, 2022 · 4 comments

Comments

@jwinarske
Copy link
Contributor

Only a single instance of Video Player is currently supported. The static plugin needs to be refactored to handle multiple views.

Currently a low priority.
@amrbadr12
Copy link

Hey! Thanks for reporting that, we currently have an issue somewhat feels related to that but not entirely sure.

We have multiple VideoPlayerController's that are initialised at the same time and when the first video ends and the second one starts playing we get this exception:

══╡ EXCEPTION CAUGHT BY SERVICES LIBRARY ╞═══════════════════════
The following FormatException was thrown during a platform
message callback:
Invalid envelope

When the exception was thrown, this was the stack:
#0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:609:7)
#1      EventChannel.receiveBroadcastStream.<anonymous closure>.<anonymous closure> (package:flutter/src/services/platform_channel.dart:498:34)
#2      EventChannel.receiveBroadcastStream.<anonymous closure>.<anonymous closure> (package:flutter/src/services/platform_channel.dart:493:47)
#3      _DefaultBinaryMessenger.setMessageHandler.<anonymous closure> (package:flutter/src/services/binding.dart:380:35)
#4      _DefaultBinaryMessenger.setMessageHandler.<anonymous closure> (package:flutter/src/services/binding.dart:377:46)
#5      _invoke2.<anonymous closure> (dart:ui/hooks.dart:190:15)
#9      _invoke2 (dart:ui/hooks.dart:189:10)
#10     _ChannelCallbackRecord.invoke (dart:ui/channel_buffers.dart:42:5)
#11     _Channel.push (dart:ui/channel_buffers.dart:132:31)
#12     ChannelBuffers.push (dart:ui/channel_buffers.dart:329:17)
#13     PlatformDispatcher._dispatchPlatformMessage (dart:ui/platform_dispatcher.dart:589:22)
#14     _dispatchPlatformMessage (dart:ui/hooks.dart:89:31)
(elided 3 frames from dart:async)

@jwinarske
Copy link
Contributor Author

that looks entirely like a Dart back trace. What branch and commit are you running on, and what package commit of video player?

Also note multiple video players are not currently supported on main or agl branches. It requires some re-work of the gstreamer plugin code.

@amrbadr12
Copy link

Good to know thanks,

For ivi-homescreen it's:
b18a478

For the video player it's:

video_player: 2.6.0
video_player_platform_interface: 5.1.4

jwinarske pushed a commit that referenced this issue Sep 27, 2023
Dev (#71)
2def8fe 
* Sanitizer Support (#69)

* Sanitizer support

-See README.md for usage
-This isolates Flutter and Wayland code into their own libraries
-homescreen is only target enabled with sanitizers

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* Fix doxygen typo

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* Resolve need to explicitly set CMake build flag for comp_surf

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* code-scanning resolutions

-Commented-out code
 https://github.com/toyota-connected/ivi-homescreen/security/code-scanning

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* Address Sanitize

-add other targets to sanitizer
-change loading type for libflutter_engine.so for sanitizer
-fix issue with isolate plugin

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* Generic logging header

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* Compiler Definitions cannot have a space after equal sign

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* Compiler Flag cleanup (#70)

* Compiler flag cleanup

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* update gstreamer texture calls

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>
jwinarske pushed a commit that referenced this issue Oct 1, 2023
Dev (#71)
29527a5 
* Sanitizer Support (#69)

* Sanitizer support

-See README.md for usage
-This isolates Flutter and Wayland code into their own libraries
-homescreen is only target enabled with sanitizers

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* Fix doxygen typo

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* Resolve need to explicitly set CMake build flag for comp_surf

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* code-scanning resolutions

-Commented-out code
 https://github.com/toyota-connected/ivi-homescreen/security/code-scanning

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* Address Sanitize

-add other targets to sanitizer
-change loading type for libflutter_engine.so for sanitizer
-fix issue with isolate plugin

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* Generic logging header

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* Compiler Definitions cannot have a space after equal sign

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* Compiler Flag cleanup (#70)

* Compiler flag cleanup

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>

* update gstreamer texture calls

Signed-off-by: Joel Winarske <joel.winarske@woven-planet.global>
@jwinarske
Copy link
Contributor Author

A rework in upcoming release will enable multiplayer scenario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwinarske @amrbadr12