Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latex.ast_fun unexpected behaviour #318

Open
AbdallahS opened this issue Dec 26, 2020 · 1 comment
Open

Latex.ast_fun unexpected behaviour #318

AbdallahS opened this issue Dec 26, 2020 · 1 comment

Comments

@AbdallahS
Copy link
Contributor

In the file src/lib/latex.ml, the function ast_fun behaves differently on x mod y than on x add y and other binary operators. This sounds strange to me and looks like a minor typo/bug.

I intend on updating the mod behaviour to match that of add and other arithmetic operators in my next patch (and then we can close this issue). If you'd rather not and tell me that the current behaviour is as intended, then I won't change it.

@AbdallahS
Copy link
Contributor Author

AbdallahS commented Dec 26, 2020

Similarly, the function Latex.is_binary_op does not treat mod appropriately. Maybe mod was added later and the code wasn't updated. Unless told otherwise, I'll change this bit too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant