Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No easy support for custom noise priors #75

Open
Aniket1998 opened this issue Dec 26, 2018 · 0 comments
Open

No easy support for custom noise priors #75

Aniket1998 opened this issue Dec 26, 2018 · 0 comments
Assignees
Labels
feature New Feature help wanted Extra attention is needed
Milestone

Comments

@Aniket1998
Copy link
Collaborator

The loss-ops and sampling from the noise priors are too entangled with one another, and the entire library is written keeping a Normal Distribution in mind for the noise prior. This leads to inconveniences such as overriding the entire train ops of a loss (and even the sampler) just to change something as minor as changing the noise prior from Normal to Uniform.

I propose having a separate set of modules for priors, keeping both fixed and learnable priors in mind. Will submit a PR regarding the same.

@Aniket1998 Aniket1998 added help wanted Extra attention is needed feature New Feature labels Dec 26, 2018
@Aniket1998 Aniket1998 self-assigned this Dec 26, 2018
@avik-pal avik-pal added this to the Version 0.0.3 milestone Jan 5, 2019
@avik-pal avik-pal pinned this issue Apr 4, 2019
@avik-pal avik-pal unpinned this issue Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New Feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants