You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The loss-ops and sampling from the noise priors are too entangled with one another, and the entire library is written keeping a Normal Distribution in mind for the noise prior. This leads to inconveniences such as overriding the entire train ops of a loss (and even the sampler) just to change something as minor as changing the noise prior from Normal to Uniform.
I propose having a separate set of modules for priors, keeping both fixed and learnable priors in mind. Will submit a PR regarding the same.
The text was updated successfully, but these errors were encountered:
The loss-ops and sampling from the noise priors are too entangled with one another, and the entire library is written keeping a Normal Distribution in mind for the noise prior. This leads to inconveniences such as overriding the entire train ops of a loss (and even the sampler) just to change something as minor as changing the noise prior from Normal to Uniform.
I propose having a separate set of modules for priors, keeping both fixed and learnable priors in mind. Will submit a PR regarding the same.
The text was updated successfully, but these errors were encountered: