Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs should emphasize loss functions with logits #116

Open
dsevero opened this issue Sep 3, 2019 · 0 comments
Open

Docs should emphasize loss functions with logits #116

dsevero opened this issue Sep 3, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@dsevero
Copy link

dsevero commented Sep 3, 2019

I noticed that minimax_discriminator_loss uses binary_cross_entropy_with_logits (cf. binary_cross_entropy) which "combines a Sigmoid layer and the BCELoss" according to the docs.

This is a good practice when it comes to numerical stability, but maybe emphasizing this in the docs would be a good idea to prevent users from inserting a sigmoid as the final non-linearity in custom models. Maybe even raising a warning if we can somehow detect this.

@dsevero dsevero added the bug Something isn't working label Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant