Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems loading files with default Android files app #127

Open
leo-petrucci opened this issue Oct 18, 2020 · 1 comment
Open

Problems loading files with default Android files app #127

leo-petrucci opened this issue Oct 18, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@leo-petrucci
Copy link

Over the past couple of days I've had some trouble loading roms on all browsers via Android phone. While I'm not 100% sure of why I have done some research and tried to pinpoint where the problem happened.

Reproducing

  1. Visit vaporboy.net
  2. In the menu, select "Open from device"
  3. Select the "Files" option when the context menu pops up
  4. Select the file
  5. Once selected you'll be brought back to the app, a loading screen will appear for a split second and then disappear.

I've actually had roms successfully load using this method a couple of times, but I've never received the "Add this to your collection" message.

If when opening "Files" to load the rom, you instead use the hamburger menu to use another File Explorer and select the rom from there, the file will load 100% of times, and the "Add to your collection" message will pop up.

I've also observed that, for some reason, if I try to load roms from "Files" from wasmboy.app, this always works.

This leads me to believe the problem resides with either:

  1. The default Android "Files" app
  2. The "Add to your collection" functionality

I was meaning to try removing it to do some testing but I've had some trouble with navigating the code. I'll report back once I've done more tests.

@torch2424 torch2424 self-assigned this Oct 19, 2020
@torch2424 torch2424 added the bug Something isn't working label Oct 19, 2020
@torch2424
Copy link
Owner

Hello @creativiii ! Thank you for following up with an issue form Twitter 😄

Thank you for the reproduction steps, and for letting me know it works with the default WasmBoy app. Than yes it's probably something specifically in the Vaporboy frontend 🤔

I was meaning to try removing it to do some testing but I've had some trouble with navigating the code. I'll report back once I've done more tests.

Yes! Please feel free to report back whatever you learn, I super appreciate the help 😄 And my apologies about the code. I made WasmBoy and VaporBoy mostly at like 3am, so my brain was usually dead so some of the code is like "Why is it like this?" 😂

But, for this issue in particular, probably has something to do in this file: https://github.com/torch2424/vaporBoy/blob/master/src/components/controlPanel/ROMSourceSelector/ROMSourceSelector.js#L339 And the line goes to the hidden file input that calls up the Android File Picker and things.

Hope that helps! And thank you for your help again! 😄 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants