Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lvmd hardcodes binary paths, crashes in nixos #908

Closed
mlazowik opened this issue May 5, 2024 · 1 comment · Fixed by #915
Closed

lvmd hardcodes binary paths, crashes in nixos #908

mlazowik opened this issue May 5, 2024 · 1 comment · Fixed by #915
Labels
bug Something isn't working

Comments

@mlazowik
Copy link

mlazowik commented May 5, 2024

lvmd assumes that lvm is in /sbin/lvm, similarly with some other binaries. This is not true in e.g. nixos

Environments

  • Version: ghcr.io/topolvm/topolvm-with-sidecar:0.29.0, chart 14.1.2
  • OS: nixos

To Reproduce
Steps to reproduce the behavior:

  1. Deploy lvmd as DaemonSet on k8s with nixos nodes
  2. lvmd crashes with "failed to run command","error":"exit status 127: nsenter: failed to execute /sbin/lvm: No such file or directory"

Expected behavior
One option could be to provide binary path in config/cli arg.

@mlazowik mlazowik added the bug Something isn't working label May 5, 2024
@toshipp
Copy link
Contributor

toshipp commented May 14, 2024

Thank you for your report.
Your suggestion is valid. We'll fix it. Also, problems like those you filed can be raised on different host distributions which we don't use on CI, so we'll denote our testing distribution.

This was referenced May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants