Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogicalVolumeService updates wait for at least 1s and do not use backoffs #904

Closed
jakobmoellerdev opened this issue Apr 29, 2024 Discussed in #901 · 0 comments · Fixed by #903
Closed

LogicalVolumeService updates wait for at least 1s and do not use backoffs #904

jakobmoellerdev opened this issue Apr 29, 2024 Discussed in #901 · 0 comments · Fixed by #903
Assignees
Labels
bug Something isn't working

Comments

@jakobmoellerdev
Copy link
Contributor

Discussed in #901

Originally posted by guettli April 25, 2024
I am looking at that code, and don't understand it:

// updateSpecSize updates .Spec.Size of LogicalVolume.
func (s *LogicalVolumeService) updateSpecSize(ctx context.Context, volumeID string, size *resource.Quantity) error {
	for {
		select {
		case <-ctx.Done():
			return ctx.Err()
		case <-time.After(1 * time.Second):
		}

source

If a conflict-error happens, then waiting makes sense. But the code waits before the first attempt.

I guess you have your reasons to do that. Can you help me understand that better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
1 participant