Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can 64-bit option rely on VTK for consistency? #729

Open
jspanchu opened this issue Feb 19, 2022 · 3 comments
Open

Can 64-bit option rely on VTK for consistency? #729

jspanchu opened this issue Feb 19, 2022 · 3 comments

Comments

@jspanchu
Copy link
Contributor

jspanchu commented Feb 19, 2022

Is your feature request related to a problem? Please describe.
It is strange when we intermix code that uses vtk filters and ttk filters. Some assumptions on the 'id' data type can no longer be safe. (int vs long long, ttk::SimplexId vs vtkIdType)

Describe the solution you'd like
It would be nice if ttk::SimplexId and vtkIdType were consistent when TTK is built with ParaView/VTK support.
The cmake config script can check to see if VTK was built with support for 64-bit id type. If it were the case, then we turn on TTK_ENABLE_64_BIT_IDS. By default, this option is turned off config.cmake:98

@JonasLukasczyk
Copy link
Contributor

This seems reasonable to me. +1

@julien-tierny
Copy link
Collaborator

in principle, that makes sense.
two things:

  • we first need to carefully check that all our tests indeed work as expected when switching to 64 bits
  • we need to assess the performance loss induced by the 64 bit comparisons (instead of 32 bit comparisons) and there WILL be some.

@jspanchu
Copy link
Contributor Author

Fair enough. Let me know if there is anything I can do to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants