Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static plot recalculated in HoloMaps in w7_defects/crystalline_defects.ipynb #148

Closed
basnijholt opened this issue Mar 19, 2016 · 9 comments
Closed

Static plot recalculated in HoloMaps in w7_defects/crystalline_defects.ipynb #148

basnijholt opened this issue Mar 19, 2016 · 9 comments

Comments

@basnijholt
Copy link
Member

The plot that is not changed shouldn't be recalculated for every parameter.
@akhmerov
Copy link
Member

What do you mean?

@basnijholt
Copy link
Member Author

Spectrum is calculated for a lot of points, but doesn't change. The only thing that changes is the points on top of the spectrum.

@akhmerov
Copy link
Member

Ah, you mean an optimization inside the notebook.

@basnijholt
Copy link
Member Author

Actually ALL data is available on the first calculation.

@basnijholt
Copy link
Member Author

reminder for next iteration, create_edge_dislocation_system and create_screw_system can be combined

@basnijholt
Copy link
Member Author

sorting_mid argument is not used in get_densities

@basnijholt
Copy link
Member Author

box is missing in density plots, compare with edx_2015

@basnijholt
Copy link
Member Author

Addressed in 47c9bb0

@basnijholt
Copy link
Member Author

Closing now, issues combined in #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akhmerov @basnijholt