Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let extension ID be configured in manifest.json #431

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wkillerud
Copy link

Description

  • Makes extensionId optional.
  • Validates that ID is set either in manifest.json or in configuration for Semantic Release.

Fixes #418

Checklist

  • This PR has updated documentation
  • This PR has sufficient testing

DevQA

DevQA Prep

  • None

DevQA Steps

  • Regression test existing setup with extensionId.
  • Consider testing by setting the ID in manifest.json like in verifyConditions.test.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cant pass extensionId validation
1 participant