Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting Pydantic 2.0? #32

Open
ker-zhao opened this issue Jul 6, 2023 · 3 comments
Open

Consider supporting Pydantic 2.0? #32

ker-zhao opened this issue Jul 6, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@ker-zhao
Copy link

ker-zhao commented Jul 6, 2023

Is your feature request related to a problem? Please describe.

Hi, there. I'm using this extension, thanks a lot.
The package is not compatible with Pydantic 2.0 when I try to update pydantic to 2.0 with Poetry.
Would you consider supporting Pydantic 2.0?

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@ker-zhao ker-zhao added the enhancement New feature or request label Jul 6, 2023
@etimberg
Copy link
Collaborator

etimberg commented Jul 6, 2023

@ker-zhao thanks for filing this. Unfortunately I'm no longer at Top Hat so I don't know how this package is being used internally. That being said, I can take a look at updating this to pydantic 2.0 but it might take a few weeks as I'm moving soon and don't have a ton of free time

@noahnu
Copy link

noahnu commented Jul 7, 2023

@etimberg I'll follow up internally as well

@noahnu
Copy link

noahnu commented Jul 16, 2023

Update on my end: we use this project with fastapi and since pydantic 2 support in fastapi is still experimental, we will not be picking this up just yet. That being said, if you're interested in opening a pull request, contributions are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants