Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for existence of auth tokens before publish (validate config stage?) #368

Open
noahnu opened this issue Jun 15, 2021 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@noahnu
Copy link
Contributor

noahnu commented Jun 15, 2021

Is your feature request related to a problem? Please describe.

Better to fail early if missing auth in non-dry run mode.

Describe the solution you'd like

Some sort of config validation at the beginning of the pipeline that fails fast.

@noahnu noahnu added the enhancement New feature or request label Jun 15, 2021
@mcataford
Copy link
Member

It would make sense to have something like ajv validate the configuration object before we proceed, yeah! Fun side-effect of this: the config schema would also serve as config format documentation. 🤔

@noahnu
Copy link
Contributor Author

noahnu commented Jun 15, 2021

We do use ajv to validate the file config. The problem with auth is that it comes from yarn, and isn't passed in via CLI args or file options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants