Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there any concerns of future-proofing/compatibility? #30

Open
msacchetti opened this issue Jul 25, 2017 · 1 comment
Open

Are there any concerns of future-proofing/compatibility? #30

msacchetti opened this issue Jul 25, 2017 · 1 comment
Labels

Comments

@msacchetti
Copy link

I am using this theme to develop a large web-app and love it so far. As i get further and further along I realize that there are many things going on in the background that change how WP functions (theme init, the loading of the template files etc).

Is there any concern that future WP updates/functionality might break if the project stops being maintained?

Thanks

@jedrzejchalubek
Copy link
Collaborator

jedrzejchalubek commented Jul 26, 2017

Theme structure doesn't stand against any of WordPress principles. It does not make any actions or filters to bend WordPress in any manner.

The whole system does not have any of external dependencies (which we don't control). It is just tonik/theme + tonik/gin. It is a PHP code which only adds some custom actions and filters. They are basically decoupled from WordPress enterally.

The only components which are a little bit tightly coupled with WordPress is an Autoload and Template component.

Autoload uses localize_template to require listed files, so it can supports a child theme overwriting.

In Template component we have to recreate the logic behind get_template_part so we could achieve the "passing data" functionality. It uses localize_template and calls required actions as same as the original get_template_part function.

It should not be any problem until WordPress does not decide to make some drastic changes in these two functions (which is really unlikely, because of versioning policy of WordPress). Even so, most of the plugins out there will have the same problem.

We have a full suite of unit tests for tonik/gin package, so we in control for these custom functionalities. I encourage you to look at tonik/gin source code. Really, is not much happening there.

Ask if you have any additional question :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants