Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benjamini-Hochberg FDR control? #116

Open
erin3692 opened this issue Mar 10, 2021 · 0 comments
Open

Benjamini-Hochberg FDR control? #116

erin3692 opened this issue Mar 10, 2021 · 0 comments

Comments

@erin3692
Copy link

Hello -- I would like to suggest something that I think would provide an improvement, and that is the additional of false discovery rate control using the Benjamini-Hochberg procedure. In the tableone documentation (https://tableone.readthedocs.io/_/downloads/en/latest/pdf/, page 9), I see the BH procedure referenced as an alternative to the Bonferroni correction. It would be so helpful to have this as an option.

There are other false discovery rate control methods too (see: https://www.graphpad.com/guides/prism/latest/statistics/stat_pros_and_cons_of_the_three_met.htm?q=Benjamini), but the BH procedure is the most common -- so would potentially be the most useful.

Also, I have a question. Are the p-values currently returned by tableone adjusted p-values? Or are they the original p-values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant