Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters not implemented for FBP #421

Open
carterbox opened this issue Jun 11, 2019 · 4 comments
Open

Filters not implemented for FBP #421

carterbox opened this issue Jun 11, 2019 · 4 comments
Labels
bug A confirmed issue that needs to be fixed feature request Feature requests or discussions good first issue A simple issue that beginning level contributors can manage
Projects

Comments

@carterbox
Copy link
Member

According to the docs, filters are not implemented for FBP. However, TomoPy does not raise an error when you try to pass filter_name or filter_par with algorithm='fbp'. This would explain why, in my tests, choosing various filters for FBP did not change the reconstruction quality.

This definitely needs to be fixed in two ways:

  1. In the short term, an error should be raised when filtered are provided with FBP because they aren't applied.
  2. In the long term, filters with FBP should be implemented because FBP requires filters. Otherwise, it's just BP.
@carterbox carterbox added bug A confirmed issue that needs to be fixed feature request Feature requests or discussions good first issue A simple issue that beginning level contributors can manage labels Jun 11, 2019
@carterbox carterbox added this to Low priority in Bug Board Aug 9, 2019
@mahayusuf
Copy link

@carterbox - Just wanted to confirm whether FBP is actually only BP in tomopy? I thought "filters are not implemented" in the warning meant that there are no "additional filters" implemented on FBP because it is already filtered. But I would really like to clarify this point. Please let me know.

@carterbox
Copy link
Member Author

TomoPy does not apply any filters to your data when using the fbp method, so yes, fbp is actually just bp. You need to filter your data before handing it off to TomoPy if you want fbp.

@mahayusuf
Copy link

Thank you!!

My reconstructed data has radial gradients due to truncation artifacts I got in ROI-specific uCT scan. So I want to implement my own filter before I reconstruct using BP. So its actually great that filter and BP component of FBP are separated in tomopy!

Question: can I implement my own smooth padding filter and then use tomopy's BP for reconstruction? Is BP compatible with filters other than the standard used in FBP?

@carterbox
Copy link
Member Author

Can I implement my own smooth padding filter and then use tomopy's BP for reconstruction?

You can perform arbitrary preprocessing of your data as you choose.

Is BP compatible with filters other than the standard used in FBP?

The list of filters implemented in TomoPy is not exhaustive. There may be others that have been proposed. You will need to search the relevant scientific literature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue that needs to be fixed feature request Feature requests or discussions good first issue A simple issue that beginning level contributors can manage
Projects
Bug Board
  
Low priority
Development

No branches or pull requests

2 participants