Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior with gridrec and filter_name #395

Open
carterbox opened this issue Mar 2, 2019 · 2 comments
Open

Unexpected behavior with gridrec and filter_name #395

carterbox opened this issue Mar 2, 2019 · 2 comments
Labels
bug A confirmed issue that needs to be fixed good first issue A simple issue that beginning level contributors can manage
Projects

Comments

@carterbox
Copy link
Member

carterbox commented Mar 2, 2019

I experienced unexpected behaviour when using filters and gridrec. Given the following example,

import tomopy

# set data and theta here

for params in [
    {'algorithm': 'gridrec'},
    {'algorithm': 'gridrec', 'filter_name': 'none'},
    {'algorithm': 'gridrec', 'filter_name': None},
]:
    recon = tomopy.recon(data, theta, **params)

I would expect these reconstructions to be the same. However, they are not. Here are the reconstructed images all scaled to the same range:
# no filter_name, but the default is shepp
gridrec 001
'none'
gridrec none 001
None
gridrec none 001

This is with tomopy=1.2.1. Any thoughts? Should I correct this?

@dgursoy
Copy link
Collaborator

dgursoy commented Mar 2, 2019

Neither nones seems correct. 😳

@prjemian
Copy link
Contributor

prjemian commented Mar 2, 2019

Y'all speakin Southern a'gin? Yet I agree.

@carterbox carterbox added bug A confirmed issue that needs to be fixed good first issue A simple issue that beginning level contributors can manage labels Mar 4, 2019
@carterbox carterbox added this to Needs triage in Bug Board Aug 9, 2019
@carterbox carterbox moved this from Needs triage to Low priority in Bug Board Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue that needs to be fixed good first issue A simple issue that beginning level contributors can manage
Projects
Bug Board
  
Low priority
Development

No branches or pull requests

3 participants