From 408e526a13126214f28d7aa94926be25001a93f9 Mon Sep 17 00:00:00 2001 From: beats Date: Thu, 8 Jun 2023 14:44:17 +0300 Subject: [PATCH 1/2] dtype removed from normalize.normalize --- source/tomopy/prep/normalize.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/tomopy/prep/normalize.py b/source/tomopy/prep/normalize.py index 369134cc6..bd1f0e2b9 100644 --- a/source/tomopy/prep/normalize.py +++ b/source/tomopy/prep/normalize.py @@ -150,8 +150,8 @@ def normalize( flat = np.mean(flat, axis=0, dtype=np.float32) dark = np.mean(dark, axis=0, dtype=np.float32) elif averaging == 'median': - flat = np.median(flat, axis=0, dtype=np.float32) - dark = np.median(dark, axis=0, dtype=np.float32) + flat = np.median(flat, axis=0) + dark = np.median(dark, axis=0) else: raise ValueError( f"'averaging' must be 'mean' or 'median' not {averaging}") From 178133074c4ab2a37cd7102a67657e49d0542902 Mon Sep 17 00:00:00 2001 From: Daniel Ching Date: Mon, 9 Oct 2023 18:10:51 -0500 Subject: [PATCH 2/2] REF: Preserve intention of buggy call to np.median --- source/tomopy/prep/normalize.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/tomopy/prep/normalize.py b/source/tomopy/prep/normalize.py index bd1f0e2b9..a3139908f 100644 --- a/source/tomopy/prep/normalize.py +++ b/source/tomopy/prep/normalize.py @@ -150,8 +150,8 @@ def normalize( flat = np.mean(flat, axis=0, dtype=np.float32) dark = np.mean(dark, axis=0, dtype=np.float32) elif averaging == 'median': - flat = np.median(flat, axis=0) - dark = np.median(dark, axis=0) + flat = np.median(flat, axis=0).astype(np.float32) + dark = np.median(dark, axis=0).astype(np.float32) else: raise ValueError( f"'averaging' must be 'mean' or 'median' not {averaging}")