Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gists Display Incorrectly #36

Open
nick-thompson opened this issue Jan 9, 2013 · 6 comments
Open

Gists Display Incorrectly #36

nick-thompson opened this issue Jan 9, 2013 · 6 comments

Comments

@nick-thompson
Copy link

Thanks for the awesome theme!

I've noticed that when using the {% gist [id] %} tag, the gist renders incorrectly. I think there are some !important declarations in the Slash stylesheets that override the Gist style sheet declarations.

I haven't been able to look into it very deeply, but I wanted to give you a heads up.

@kaelin
Copy link

kaelin commented May 5, 2013

I'm seeing problems too; the code from all my gist listings gets centered. Otherwise, this seems like a very nice theme!

@emberian
Copy link
Collaborator

Gist handling is currently terrible, and I think it's going to require some careful refactoring to work around. Ideally I'd be able to shove the gist into an iframe and apply styles to it in a sandbox. The github embed code just spews a div into the DOM

@emberian
Copy link
Collaborator

On the other hand, octopress 2.1 does things a lot differently with the gist plugin... will wait for that I suppose.

@sprig
Copy link

sprig commented May 3, 2014

Hello and thanks for the theme!

Are there any updates regarding this issue?

@sprig
Copy link

sprig commented May 3, 2014

From what I found here: http://devspade.com/blog/2013/08/06/fixing-gist-embeds-in-octopress/
this might be a problem that is not confined to this theme. Also from that post I found (and verified) that adding:

.gist-file {
  font-size:.8em !important;
}

table.lines{
  width: 100%;
}

to octopress/sass/custom/_style.css fixes the problem (for me). Perhaps something similar should just be included in the theme?

@emberian
Copy link
Collaborator

emberian commented May 4, 2014

@sprig awesome, glad someone finally found a workaround! Want to send a pull request with those changes? I'll merge that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants