Support for Central Package Management

[OwnageIsMagic]

Packages versions can be specified in Directory.Packages.props.
https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management
or at least add warning if this file is detected

[sensslen]

Have you tried 3.0.0-alpha? This version of the tool should consider these packages...

[galadril]

Any idea when this gets merged to the main version?

It looks like the latest alpha isnt on the same level as 2.7.1

[galadril]

any news on the v3 alpha?

[sensslen]

@tomchavakis how do you feel about releasing version 3 to the public?

[jeroenhabets]

@tomchavakis as part of our .Net 8.0 migration (now GA!) we also embraced Central Package Management so a (NuGet) 3.0 release would be much appreciated

Is there anything we can do to help?

For anyone stumbling upon this issue, to unblock our license check we upgrade this tool to its prerelease version as a workaround:

dotnet tool update --global dotnet-project-licenses --prerelease

P.S. Note that the command line arguments have changed a lot, and e.g. the -u we used for uniqueness is no longer supported instead the output nicely lists the different occurrences under one entry:

dotnet-project-licenses -o JsonPretty -i EAssessment.WebApp.sln > licenses.json

[sensslen]

@jeroenhabets It seems @tomchavakis is unavailable for quite some time now. I do have write permissions to the repo. Would you willing to help me making v3.0.0 ready for prime time? There is #201 which updates the prerelease version. Once this change is in, I think we could merge.

[jeroenhabets]

Hi @sensslen, I have just left my previous job and am no longer involved in a .Net project.
Your PR #201 is huge. Are you looking for help getting it reviewed? Not sure if my previous team (e.g. @ddmm-white) can help out there or we'll have to wait for @tomchavakis to come back online.

[sensslen]

@jeroenhabets Yes, I'm looking for help reviewing it. I'ts not that huge once you take a closer look...

[jeroenhabets]

@sensslen well in PR #201 I see 261 files changed, and as you wrote in the description not only .Net8 support added but also NuGet updates and Moq replaced with NSubstitute. Furthermore, though I'm no expert but, it looks like you also did quite a bit of refactoring (some small/oneliners _ignoredPackages.Any( to Array.Exists( that are new to me (for performance?), some larger)

The .Net8 + NuGet part looks fine, but as I lack the .Net developer experience (no expert) I do not feel comfortable saying much about the rest TBH.

My 2ct: IMHO to facilitate review, it would be better to split the work into separate PRs. Or find a senior .Net engineer that can review it whole (I can no longer arrange that as I've left the project).

[sensslen]

I just released https://www.nuget.org/packages/nuget-license. This is a release of my fork of v3.0.0 of this tool. Unfortunately @tomchavakis has been unresponsive for quite some time and the nuget api key expired which means I was unable to release in the original form.