Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Images are not saved #234

Open
nickbe opened this issue Mar 11, 2021 · 8 comments
Open

Inline Images are not saved #234

nickbe opened this issue Mar 11, 2021 · 8 comments

Comments

@nickbe
Copy link

nickbe commented Mar 11, 2021

I can paste an image from my clipboard into a note (windows), but it doesn't seem to be get saved.

@davidbannon
Copy link
Member

While the underlying component used for editing a note, kmemo, can handle images, the tomboy standard file format cannot. The original Tomboy did not handle images.

So, all that needs to be done to image enable tomboy-ng is to determine how and where the image data is saved. When I first started out, there were still a lot of Tomboy users so I have been careful to comply with the Tomboy format, not sure thats so important now.

So far, over several years, I have had only one request to add images to tomboy-ng so I have not worried about it.

Davo

@nickbe
Copy link
Author

nickbe commented Mar 12, 2021

Well I think that depending on what you do with your notes, images are important enough nowadays. For example I'm making a lot of notes regarding design aspects and other things which require screenshots.
Maybe it would be a nice idea to let the user choose between two formats. A standard richtext in delphi when saved should handle inline coded images pretty well. So yea I think it would be great to have that.

Cheers
Nick

@nickbe
Copy link
Author

nickbe commented Jul 26, 2021

Any news regarding this? Basically the missing option to use inline images still prevents me from using tomboy finally. I still think that it should be possible nowadays.

@davidbannon
Copy link
Member

No, sorry Nick, no news either way. My issue is that its a big departure from the standard Tomboy note format, a big change to saving and loading. If you paste in an image, I'll need to scale it in some way, most people who have images these days have something like 3000x2000 pixels ! A lot of extra code.

Lots of decisions to be made about how its done and, it seems, only one person with any interest in it.

I need to establish a planning committee :-)

But definitely not a 'no' yet.

Davo

@nickbe
Copy link
Author

nickbe commented Oct 23, 2021

Hey David. Why is the note format still such a concern? I think through the years there should also be advancement. And having an option to finally just copy paste an image inline would be a big advancement.

But I understand that this might also be a difficult decision. Maybe there could be a switch in the settings ("use new save format") would be an approach?

@aguador
Copy link
Contributor

aguador commented Oct 26, 2021

Your argument about screenshots has merit, but I recall an article that I cannot find arguing that Evernote and other programs that allow images are just a distraction from the content. I have not been able to find that post, but my word-oriented self rather liked it. The closest I have come is this:

https://lifehacker.com/i-still-use-plain-text-for-everything-and-i-love-it-1758380840

For me the ability to search on text is much more important, but that does not mean everyone must be happy with that. We will see if Davo comes up with a solution...

@fuzzy7k
Copy link

fuzzy7k commented Apr 23, 2023

I agree that adding inline picture display would be a burden. Implementing that cross platform would not be fun.
Do they need to be inline though, or can they just be links?
I rather like having links to images. It keeps the focus on the content with access to a visual.

In that case, maybe a working implementation for the paste use case would just be for tomboy to save the file somewhere and insert a link. I am assuming that tomboy-ng can recognizes file uri's and make them clickable.

@davidbannon
Copy link
Member

Yes, Fuzzy, I have played a bit, more as a thought experiment than in code, along those lines. The simplest approach would be an in line link pointing to a user managed image.

Next, maybe a small, fixed size 'thumbnail' image if you hover the mouse over the link, or just a text hint with the image name. Click it and we open the real image with what ever the user's favorite image viewer is. Focus moves from the note to the image viewer.

In that sort of thing, tomboy is not managing the images at all, the user just inserts a link to an image of their keeping. So, tomboy-ng would make no attempt to sync or archiving the images, if the note appears on a second machine and that image is not there, NMP (not my problem).

I am not sure thats satisfactory enough for me to present as a solution .....

Davo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants