Skip to content

Latest commit

 

History

History
239 lines (182 loc) · 9.66 KB

CONTRIBUTING.md

File metadata and controls

239 lines (182 loc) · 9.66 KB
Raw

Contributing To Timex

I've thrown together some guidelines around how to contribute to timex so it's smooth sailing for everyone. Please take some time and read through this before creating a pull request. Your contributions are hugely important to the success of timex, and I appreciate all your help!

Issues Tracker

I use the issues tracker to do the following things:

  • requests for consideration (RFC) - These are things which I, or you perhaps, am soliciting feedback on, in order to flesh out ideas, potential features, or big changes. If you have an idea, or a feature you'd like to implement, feel free to create issues that fit that definition, and I'll give them the RFC label.
  • bug reports - Anything you encounter with timex that is broken or is generally bad behavior, create an issue for it, and I'll label it appropriately.
  • submitting pull requests - If you found and fixed a bug in timex, please submit a PR with your changes! See the link for guidelines on PRs.

All issues are given a difficulty classification between starter and advanced. This is so people that are interested in contributing can pick off an issue that is of an appropriate difficulty they are comfortable with. Issues open for contributions are marked with the help wanted label, those without this label are things I'm debating opening up for contribution, but haven't decided how I want them done yet, or are things I'm currently working on myself. If you are new to the project, please start with one of the starter or intermediate bugs, as most of the stuff classified as advanced require intimate knowledge of the project internals. Regardless of level, if it's something you feel you want to tackle, leave a comment and let me know, and we can discuss it in more detail.

Please leave a comment on the issue you are working on before starting, so that everyone knows it's off limits, and so myself or others can discuss implementation if necessary. You don't need to wait for a response before starting, but it will help ensure nobody ends up doing duplicate work.

Bug Reports

A bug is a demonstrable problem that is caused by the code in the repository. The bug must be reproducible against the master branch.

Guidelines for bug reports:

  1. Use the GitHub issue search — check if the issue has already been reported.

  2. Check if the issue has been fixed — try to reproduce it using the master branch in the repository.

  3. Isolate and report the problem — ideally create a reduced test case. Only report bugs which are present on the current master branch. Bugs which occur in previous releases but are fixed in master will be closed as invalid.

Please try to be as detailed as possible in your report. Include information about your operating system, your Erlang and Elixir versions (i.e. 17.1.2, or 1.0.2). Provide steps to reproduce the issue as well as the outcome you were expecting. All these details will help other developers to find and fix the bug.

Example:

Short and descriptive example bug report title

A summary of the issue and the environment in which it occurs. If suitable, include the steps required to reproduce the bug.

  1. This is the first step
  2. This is the second step
  3. Further steps, etc.

<url> - a link to the reduced test case (e.g. a GitHub Gist or project repo)

Any other information you want to share that is relevant to the issue being reported. This might include the lines of code that you have identified as causing the bug, and potential solutions (and your opinions on their merits).

Feature Requests

Feature requests are absolutely welcome, but before you dive in to implementing an idea, please open up an issue on the tracker as a request for consideration by creating the title of your issue prefixed with RFC.

Example:

RFC: Some feature that would be super awesome

A description of the new feature and why it's needed. This should open up discussion and provide a starting point for other participants to give their thoughts on whether the feature makes sense, what the best path to implementation is, etc. If you made code changes to validate your idea, link the url so others can look at the work you've done.

Feature requests will be discussed by the community, and the final vote will be made by me on whether or not it fits within the goals of the project. If there is strong merit for a feature to be implemented, you can be assured I will be interested in making it happen.

Contributing

Timex is composed of the following general components:

  • The Timex module, which is the primary API for the library
  • The Timex.Date module, which is where all Date specific APIs reside
  • The Timex.DateTime module, which is where all DateTime specific APIs reside
  • The Timex.Time namespace, containing the Time API as well as the Time formatting API.
  • The Timex.Format namespace, containing all code related to string formatting. This includes the behavior for custom formatting plugins.
  • The Timex.Parse namespace, containing all code related to parsing.
  • The Timex.Timezone namespace, containing all code related to the parsing of tzdata, querying timezones, determining the local timezone for a given date, etc.

The following must be done for all PRs (where applicable):

  • Functions must have docs, see existing code for examples of what I'm expecting.
  • Functions must have typespecs. Please re-use existing typespecs where applicable.
  • Use comments, but please only use them to explain why a particular piece of code does what it does, do not use them to explain how - that should be self-evident.
  • Ensure your code is formatted and written to match the existing style of the project.
  • Make sure you write tests to cover the code you wrote. PRs with no associated tests will likely be left unmerged until there is test coverage. If no tests are needed, just make sure you address that in your PR commentary.

After your changes are done, please remember to run the full test suite with mix test.

With tests running and passing, and your documentation done, your ready to send a PR!

Contributing Documentation

Please make sure all modules are well documented with a @moduledoc, any relevant @typedocs and all public functions documented with @doc and @spec. Use examples where possible (especially in doctest format if it's possible). There may be legacy code still in there without these, so if you see them, feel free to make a pull request to add more docs!

Example:

@doc """
Return only those elements for which `fun` is true.

## Examples

    iex> Enum.filter([1, 2, 3], fn(x) -> rem(x, 2) == 0 end)
    [2]

"""
def filter(collection, fun) ...

Pull requests

Good pull requests - patches, improvements, new features - are a fantastic help. They should remain focused in scope and avoid containing unrelated commits.

IMPORTANT: By submitting a patch, you agree that your work will be licensed under the license used by the project.

If you have any large pull request in mind (e.g. implementing features, refactoring code, etc), please ask first otherwise you risk spending a lot of time working on something that the project's developers might not want to merge into the project.

Please adhere to the coding conventions in the project (indentation, accurate comments, etc.) and don't forget to add your own tests and documentation. When working with git, we recommend the following process in order to craft an excellent pull request:

  1. Fork the project, clone your fork, and configure the remotes:

    # Clone your fork of the repo into the current directory
git clone https://github.com/<your-username>/timex
# Navigate to the newly cloned directory
cd timex
# Assign the original repo to a remote called "upstream"
git remote add upstream https://github.com/bitwalker/timex

  2. If you cloned a while ago, get the latest changes from upstream:

    git checkout master
git pull upstream master

  3. Create a new topic branch (off of master) to contain your feature, change, or fix.

    IMPORTANT: Making changes in master is discouraged. You should always keep your local master in sync with upstream master and make your changes in topic branches.

    git checkout -b <topic-branch-name>

  4. Commit your changes in logical chunks. Keep your commit messages organized, with a short description in the first line and more detailed information on the following lines. Feel free to use Git's interactive rebase feature to tidy up your commits before making them public.

  5. Make sure all the tests are still passing.

    mix test

  6. Push your topic branch up to your fork:

    git push origin <topic-branch-name>

  7. Open a Pull Request with a clear title and description.

  8. If you haven't updated your pull request for a while, you should consider rebasing on master and resolving any conflicts.

    IMPORTANT: Never ever merge upstream master into your branches. You should always git rebase on master to bring your changes up to date when necessary.

    git checkout master
git pull upstream master
git checkout <your-topic-branch>
git rebase master

Thank you for your contributions!